# HG changeset patch # User Thierry Florac # Date 1496914480 -7200 # Node ID cedc7584a81f3ef4bd24c06747c9d31be5be9684 # Parent 4e3b341baaec8bfa17f226ae29eb1de5ac112746 Added mailer check diff -r 4e3b341baaec -r cedc7584a81f src/pyams_content/shared/common/review.py --- a/src/pyams_content/shared/common/review.py Tue Jun 06 17:13:27 2017 +0200 +++ b/src/pyams_content/shared/common/review.py Thu Jun 08 11:34:40 2017 +0200 @@ -139,7 +139,10 @@ if sender_mail_info is not None: for sender_name, sender_address in sender_mail_info.get_addresses(): break - mailer = query_utility(IMailer, name=settings.mailer) + if settings.enable_notifications: + mailer = query_utility(IMailer, name=settings.mailer) + else: + mailer = None # create message message_body = self.review_template(request=request, context=self.context, @@ -151,7 +154,9 @@ notifications = 0 readers = roles.readers for reviewer in reviewers: - if settings.enable_notifications and (notify_all or (reviewer not in readers)): + if settings.enable_notifications and \ + (mailer is not None) and \ + (notify_all or (reviewer not in readers)): principal = security.get_principal(reviewer, info=False) if not isinstance(principal, MissingPrincipal): mail_info = IPrincipalMailInfo(principal, None)